Post by Radrin
This is my current build, works great for grinding stuff up, and PvP, as well as raids. It's not fantastic, and I'm sure theres some stuff I messed up, but it's worked remarkably well for me so far. Just remember that +spelldamage/Shadowdamage for this spec is key. And that you are slightly squishy :(
Post by Dunsinane
Glad to see your post. Looks like you're genuinely interested in learning. I can respect that. :-)
To address your questions:
Suppression is a good thing - in specific circumstances. The +spell hit bonus only applies to your affliction spells and so the talent is much better in deep affliction builds, which yours is not. Also, the hit cap against other players is reached with only two points in the talent. It should also be replaced by +spell hit gear/enchants fairly quickly at 70.
Improved Voidwalker is a so-so talent at best. Voidwalker grinding is less efficient than drain tanking or felguard grinding. It is a horrible PvP pet. The "oh, &$#*%@" button only gives you an extra 900 shield, which isn't much when the swarms of mobs are coming your way. If you insist on VW grinding, fine, take the talent, but you're gimping yourself.
On to PvP builds:
There are three typical approaches to PvP builds. All are highly effective in a variety of circumstances.
1) UA/Shadowburn (41/7/11 +2)http://www.wowhead.com/?talent=Ii0rVRfkqtbobxZxx0z
You have two points to spare for any other talent you'd like to have. The key survival talents in demonology are there, as is shadowburn for some extra burst. You have a ton of instants and a very deep bag of tricks, especially as you'll be running with the felhunter most of the time. Enemy casters will hate you, melee is a problem unless you can keep them at a distance - be sure to put warriors into combat with CoEx before they can get a charge off.
When undergeared in BGs, you can make yourself very effective through CC. Improved Howl of Terror is an excellent line-breaker in Alterac Valley as well as a means of clearing melee off of you. As your shadow damage builds, your punch grows in leaps and bounds. Dot everything, drain liberally, and take full advantage of Nightfall and your mobility.
This is also an excellent all-around build. It grinds very well and isn't gimped for instances and raids.
2) Felguard (5/43/11 +2)http://www.wowhead.com/?talent=IVZbxczIizMesuxx0z
Again, you have two points to spare. Common choices are Improved Life Tap and 5/5 Demonic Tactics. Like the build above, this is an excellent all-around build.
This build's strengths are its survivability (with Soul Link, Demonic Resilience, Master Demonologist and Fel Stamina added in), the felguard itself, and some very good boosts to your shadow damage from the late talents in the tree. This one is extremely popular in BGs and a little less so in arena. It lacks the flexibility of UA/Shadowburn, is stronger against melee, and weaker against casters - particularly other warlocks who will simply banish your pet and take away a huge chunk of your bonuses.
Typically this build will have you sitting in the back lines casting while your felguard is in among the enemy creating havoc. You save intercept to interrupt a heal or to pull a rogue off of yourself. Learning to micromanage your pet is important. When left alone, you can carve large chunks out of the opposition.
3) Siphon Life/Soul Link (SL/SL) (26/35/0)http://www.wowhead.com/?talent=Iq0rVRfkoZbxczIizzeo
There are a number of variants to this build that add Demonic Knowledge, 2/5 Suppression, or more Mana Feed.
This is the warlock survival spec. You give up on having a lot of punch and instead focus on making yourself as annoying to kill as possible. Siphon Life plus Drain Life plus Demonic Resilience plus a Soul Link felhunter (that you can almost instantly resummon on the off chance it gets killed) combine to give you a huge health pool, magic resistances, and damage mitigation. As a result, this spec is geared toward arenas more than BGs.
Your basic strategy is to take the enemy hits while gaining control of the fight at a key moment with either Death Coil, Fear, or Spell Lock. At that point you keep him CCd while you refill yourself on his health or take away the last of his mana, then blow away the poor, exhausted fool.
This spec is very poor outside of PvP. It does not grind well, and is very gimped in a group situation.